Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758172AbaLJU5H (ORCPT ); Wed, 10 Dec 2014 15:57:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41502 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758053AbaLJU5G (ORCPT ); Wed, 10 Dec 2014 15:57:06 -0500 Message-ID: <1418245000.23374.26.camel@t520.localdomain> Subject: arm64 hitting BUG in arch_timer.h From: Mark Salter To: linux-arm-kernel Cc: linux-kernel , Sonny Rao Date: Wed, 10 Dec 2014 15:56:40 -0500 Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using Linus' tree from this morning, I am hitting: [ 0.000000] BUG: failure at ./arch/arm64/include/asm/arch_timer.h:112/arch_counter_get_cntpct! This is triggered by commit 0b46b8a718 ("clocksource: arch_timer: Fix code to use physical timers when requested") which addresses an armv7 problem. Arm64 wants to always use a virtual timer. I used this to avoid the BUG and get a booting kernel: diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch index 71846f9..4d8a01e 100644 --- a/drivers/clocksource/arm_arch_timer.c +++ b/drivers/clocksource/arm_arch_timer.c @@ -468,7 +468,7 @@ static void __init arch_counter_register(unsigned type) /* Register the CP15 based counter if we have one */ if (type & ARCH_CP15_TIMER) { - if (arch_timer_use_virtual) + if (IS_ENABLED(CONFIG_ARM64) || arch_timer_use_virtual) arch_timer_read_counter = arch_counter_get_cntvct; else arch_timer_read_counter = arch_counter_get_cntpct; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/