Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934472AbaLKJ7w (ORCPT ); Thu, 11 Dec 2014 04:59:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:44056 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932698AbaLKJ7q convert rfc822-to-8bit (ORCPT ); Thu, 11 Dec 2014 04:59:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,556,1413270000"; d="scan'208";a="652136162" From: "Varlese, Marco" To: John Fastabend , Jiri Pirko CC: "netdev@vger.kernel.org" , "stephen@networkplumber.org" , "Fastabend, John R" , "roopa@cumulusnetworks.com" , "sfeldma@gmail.com" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration Thread-Topic: [RFC PATCH net-next 1/1] net: Support for switch port configuration Thread-Index: AdAUhPtXGtfGamc6R3Ssf+89G79LDwAFGVwAAAB5JYAAIzgFYA== Date: Thu, 11 Dec 2014 09:59:42 +0000 Message-ID: References: <20141210165018.GG1863@nanopsycho.orion> <54887CF7.70708@gmail.com> In-Reply-To: <54887CF7.70708@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: John Fastabend [mailto:john.fastabend@gmail.com] > Sent: Wednesday, December 10, 2014 5:04 PM > To: Jiri Pirko > Cc: Varlese, Marco; netdev@vger.kernel.org; > stephen@networkplumber.org; Fastabend, John R; > roopa@cumulusnetworks.com; sfeldma@gmail.com; linux- > kernel@vger.kernel.org > Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port > configuration > > On 12/10/2014 08:50 AM, Jiri Pirko wrote: > > Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varlese@intel.com wrote: > >> From: Marco Varlese > >> > >> Switch hardware offers a list of attributes that are configurable on > >> a per port basis. > >> This patch provides a mechanism to configure switch ports by adding > >> an NDO for setting specific values to specific attributes. > >> There will be a separate patch that extends iproute2 to call the new > >> NDO. > > > > > > What are these attributes? Can you give some examples. I'm asking > > because there is a plan to pass generic attributes to switch ports > > replacing current specific ndo_switch_port_stp_update. In this case, > > bridge is setting that attribute. > > > > Is there need to set something directly from userspace or does it make > > rather sense to use involved bridge/ovs/bond ? I think that both will > > be needed. > > +1 > > I think for many attributes it would be best to have both. The in kernel callers > and netlink userspace can use the same driver ndo_ops. > > But then we don't _require_ any specific bridge/ovs/etc module. And we > may have some attributes that are not specific to any existing software > module. I'm guessing Marco has some examples of these. > > [...] > > > -- > John Fastabend Intel Corporation We do have a need to configure the attributes directly from user-space and I have identified the tool to do that in iproute2. An example of attributes are: * enabling/disabling of learning of source addresses on a given port (you can imagine the attribute called LEARNING for example); * internal loopback control (i.e. LOOPBACK) which will control how the flow of traffic behaves from the switch fabric towards an egress port; * flooding for broadcast/multicast/unicast type of packets (i.e. BFLOODING, MFLOODING, UFLOODING); Some attributes would be of the type enabled/disabled while other will allow specific values to allow the user to configure different behaviours of that feature on that particular port on that platform. One thing to mention - as John stated as well - there might be some attributes that are not specific to any software module but rather have to do with the actual hardware/platform to configure. I hope this clarifies some points. ----------------------------------------------------------- Marco Varlese - Intel Corporation ----------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/