Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934396AbaLKU4P (ORCPT ); Thu, 11 Dec 2014 15:56:15 -0500 Received: from mail-qg0-f51.google.com ([209.85.192.51]:47393 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934584AbaLKUz3 (ORCPT ); Thu, 11 Dec 2014 15:55:29 -0500 MIME-Version: 1.0 In-Reply-To: <54899F0E.4090309@ti.com> References: <54899F0E.4090309@ti.com> Date: Thu, 11 Dec 2014 12:55:28 -0800 X-Google-Sender-Auth: A1O19dA5l5C7hjHKrz1v1Skk5E4 Message-ID: Subject: Re: [GIT PULL] fbdev fixes for 3.19 From: Linus Torvalds To: Tomi Valkeinen , Grant Likely , Rob Herring , "Rafael J. Wysocki" Cc: LKML , Linux Fbdev development list , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 11, 2014 at 5:41 AM, Tomi Valkeinen wrote: > > Please pull fbdev changes for 3.19. Ugh. I've pulled it, but I'm not a huge fan of commit 6d09dc6b74ca ("of.h: Keep extern declaration of of_* variables when !CONFIG_OF"). I guess it works, but it ends up delaying any failures from compile time to link time, and the linker error messages likely won't be great. So I'm cc'ing the OF people and Rafael (who worked on OF/ACPI unification) to see if they have comments, preferences, or other ways to solve this. Quite frankly, to me it smells like non-OF builds should just have an empty "for_each_child_of_node ()" define instead of playing games with externs that then end up not existing, and depending on the compiler DTRT. Comments? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/