Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759268AbaLLA75 (ORCPT ); Thu, 11 Dec 2014 19:59:57 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:41438 "EHLO mail-qa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757702AbaLLA7z (ORCPT ); Thu, 11 Dec 2014 19:59:55 -0500 MIME-Version: 1.0 In-Reply-To: <3272093.0A5V5UZ3cA@vostro.rjw.lan> References: <54899F0E.4090309@ti.com> <3272093.0A5V5UZ3cA@vostro.rjw.lan> From: Rob Herring Date: Thu, 11 Dec 2014 18:59:34 -0600 Message-ID: Subject: Re: [GIT PULL] fbdev fixes for 3.19 To: "Rafael J. Wysocki" Cc: Linus Torvalds , Tomi Valkeinen , Grant Likely , Rob Herring , "Rafael J. Wysocki" , LKML , Linux Fbdev development list , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 11, 2014 at 4:58 PM, Rafael J. Wysocki wrote: > On Thursday, December 11, 2014 12:55:28 PM Linus Torvalds wrote: >> On Thu, Dec 11, 2014 at 5:41 AM, Tomi Valkeinen wrote: >> > >> > Please pull fbdev changes for 3.19. >> >> Ugh. I've pulled it, but I'm not a huge fan of commit 6d09dc6b74ca >> ("of.h: Keep extern declaration of of_* variables when !CONFIG_OF"). >> >> I guess it works, but it ends up delaying any failures from compile >> time to link time, and the linker error messages likely won't be >> great. >> >> So I'm cc'ing the OF people and Rafael (who worked on OF/ACPI >> unification) to see if they have comments, preferences, or other ways >> to solve this. >> >> Quite frankly, to me it smells like non-OF builds should just have an >> empty "for_each_child_of_node ()" define instead of playing games with >> externs that then end up not existing, and depending on the compiler >> DTRT. >> >> Comments? > > "for_each_child_of_node ()" is not a problem here AFAICS, because in the > example from the commit changelog the compiler would complain on the > of_chosen instance in the "if ()" statement already anyway if I'm not mistaken. Really, the "if" should be completely removed here. for_each_child_of_node should do the right thing for !OF or if of_chosen is NULL already. Since for_each_child_of_node relies on it's helper function to get optimized away we need of_chosen defined to something. I believe Linus' suggestion was we could have an empty for_each_child_of_node() define, but we've moved away from that to simplify the of.h header and avoid multiple definitions. Doing that has it's own issues. Fixing up !OF problems has been somewhat painful as we've converted ARM and people failed to test that. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/