Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934075AbaLLHpZ (ORCPT ); Fri, 12 Dec 2014 02:45:25 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:37841 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933852AbaLLHpV (ORCPT ); Fri, 12 Dec 2014 02:45:21 -0500 X-Listener-Flag: 11101 Subject: Re: [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile From: Eddie Huang To: Matthias Brugger CC: Yingjoe Chen , Rob Herring , Jason Cooper , srv_heupstream , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Thomas Gleixner , Olof Johansson , Robert Richter , Mark Brown , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Sascha Hauer , YH Chen =?UTF-8?Q?=28=E9=99=B3=E6=98=B1=E8=B1=AA=29?= In-Reply-To: References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-4-git-send-email-eddie.huang@mediatek.com> <1418221662.21309.13.camel@mtksdaap41> <1418302026.1992.18.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" Date: Fri, 12 Dec 2014 15:45:17 +0800 Message-ID: <1418370317.423.8.camel@mtksdaap41> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On Thu, 2014-12-11 at 14:02 +0100, Matthias Brugger wrote: > Hi Eddie, > > 2014-12-11 13:47 GMT+01:00 Eddie Huang : > > On Wed, 2014-12-10 at 15:50 +0100, Matthias Brugger wrote: > >> 2014-12-10 15:27 GMT+01:00 Yingjoe Chen : > >> > > >> > Hi, > >> > > >> > On Wed, 2014-12-10 at 18:50 +0800, Eddie Huang wrote: > >> > <...> > >> >> diff --git a/arch/arm64/boot/dts/mt8173-evb.dts b/arch/arm64/boot/dts/mt8173-evb.dts > >> >> new file mode 100644 > >> >> index 0000000..adf26dd > >> >> --- /dev/null > >> >> +++ b/arch/arm64/boot/dts/mt8173-evb.dts > >> > <...> > >> >> + timer { > >> >> + compatible = "arm,armv8-timer"; > >> >> + interrupt-parent = <&gic>; > >> >> + interrupts = <1 13 0x8>, > >> >> + <1 14 0x8>, > >> >> + <1 11 0x8>, > >> >> + <1 10 0x8>; > >> >> + clock-frequency = <13000000>; > >> > > >> > I believe our firmware doesn't need this line. Please remove it. > >> > >> The point here would be to know if you need to enable a special timer > >> from the mtk-timer block to get the arch timer working. > >> In any case, you will need some sort of timer. This dts does not > >> describe the mtk-timer (may in the mt8173 it does not exist) but > >> defines the clocks clk26m and clk32k. So if you don't use the > >> mtk-timer, please remove the clocks as there isn't a block using them. > >> > > > > MT8173 has two timer set: CPUGPT and APBGPT, and use CPUGPT to enable > > arch_timer. Previous series only have APBGPT. MT8173 still need enable > > CPUGPT to get arch timer working, we put this in loader, and transparent > > to kernel. So I will remove clk26m and clk32k in next version. > > Ok, so if this is done in the bootloader, there shouldn't be a problem > then. Perfect. > > Just one more comment on the dts nodes. Can you use the makros defined > for the interrupt type > e.g "GIC_PPI 14 IRQ_TYPE_LEVEL_LOW" instead of "1 14 0x8". This makes > the dts easier to read. > > Thanks, > Matthias > 3.18 still don't have following patch http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/301425.html So I can't use interrupt macro in mt8173.dtsi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/