Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966037AbaLLK5d (ORCPT ); Fri, 12 Dec 2014 05:57:33 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:13234 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933987AbaLLK5b (ORCPT ); Fri, 12 Dec 2014 05:57:31 -0500 Message-ID: <548ABC22.3080107@atmel.com> Date: Fri, 12 Dec 2014 10:57:54 +0100 From: Cyrille Pitchen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: David Laight , "'Thomas Petazzoni'" CC: "nicolas.ferre@atmel.com" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "soren.brinkmann@xilinx.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/1] net/macb: add TX multiqueue support for gem References: <87a3098203ee6eaa7a60607713a293d3258e2b58.1418291637.git.cyrille.pitchen@atmel.com> <20141211203103.4191887a@free-electrons.com> <063D6719AE5E284EB5DD2968C1650D6D1CA0BA36@AcuExch.aculab.com> <548AAE66.8070501@atmel.com> <063D6719AE5E284EB5DD2968C1650D6D1CA0BA7D@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CA0BA7D@AcuExch.aculab.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 12/12/2014 10:59, David Laight a ?crit : > From: Cyrille Pitchen [... >>> It will probably add a lot of object code and, depending on how often >>> the registers are accesses, might have performance impact. >>> >>> Having: >>> #define GEM_ISR(n) (0x400 + (n) << 4) >>> will save source code. >>> >>> David >>> >>> >>> >> So you suggest that we keep the unsigned int fields ISR, IMR, IER, IDR, TBQP in >> the struct macb_queue and initialize them once for all in macb_probe() like >> patch v2 does but only replace the GEM_ISR1 .. GEM_ISR7 defines by GEM_ISR(n) >> in macb.h? >> >> This way there would be to test at run time and we can handle the special >> register mapping of queue0. >> >> Is it what you meant? > > In one word, yes. > > David > > > OK, so I'm working on v3 Thanks Cyrille -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/