Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030884AbaLLQn1 (ORCPT ); Fri, 12 Dec 2014 11:43:27 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:59315 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030687AbaLLQnZ (ORCPT ); Fri, 12 Dec 2014 11:43:25 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 96.249.243.124 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18lAGKY2BY6bG3+GCAYGGtaHcCbvE2KobU= X-DKIM: OpenDKIM Filter v2.0.1 titan 015E262FBF0 Date: Fri, 12 Dec 2014 11:42:54 -0500 From: Jason Cooper To: Eddie Huang Cc: Mark Rutland , Matthias Brugger , Rob Herring , "srv_heupstream@mediatek.com" , Pawel Moll , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Thomas Gleixner , Olof Johansson , "Joe.C" , Robert Richter , Mark Brown , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Sascha Hauer , "yh.chen@mediatek.com" Subject: Re: [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile Message-ID: <20141212164254.GK22670@titan.lakedaemon.net> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-4-git-send-email-eddie.huang@mediatek.com> <20141211180245.GE28150@leverpostej> <1418371705.423.31.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418371705.423.31.camel@mtksdaap41> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 12, 2014 at 04:08:25PM +0800, Eddie Huang wrote: > On Thu, 2014-12-11 at 18:02 +0000, Mark Rutland wrote: > > On Wed, Dec 10, 2014 at 10:50:01AM +0000, Eddie Huang wrote: ... > > > + memory { > > > > Nit: should be memory@40000000 (and you'll need to add device_type = > > "memory"). > > > > > + reg = <0 0x40000000 0 0x40000000>; > > > + }; > > skeleton.dtsi already has /memory node with address-cells=2, > size-cells=1, which will cause build warning if I change to use > memory@40000000, because we use size-cells=2. I will not include > skeleton.dtsi and follow your suggestion in next version. There's skeleton64.dtsi in arch/arm/boot/dts (arm 32bit has LPAE-enabled systems). Perhaps we should come up with a way to share both across the arches? hth, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/