Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935264AbaLLSRG (ORCPT ); Fri, 12 Dec 2014 13:17:06 -0500 Received: from mo2.mail-out.ovh.net ([178.32.228.2]:54050 "EHLO mo2.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935145AbaLLSRF convert rfc822-to-8bit (ORCPT ); Fri, 12 Dec 2014 13:17:05 -0500 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: [PATCH] clk: rockchip: add CLK_IGNORE_UNUSED flag to fix USB Host From: NEO-Technologies / Julien CHAUVEAU In-Reply-To: Date: Fri, 12 Dec 2014 19:01:23 +0100 Cc: Heiko Stuebner , Mike Turquette , Stephen Boyd , "moderated list:ARM/Rockchip SoC..." , "open list:ARM/Rockchip SoC..." , "open list:COMMON CLK FRAMEWORK" Content-Transfer-Encoding: 8BIT Message-Id: References: <1418396066-31360-1-git-send-email-julien.chauveau@neo-technologies.fr> To: Romain Perier X-Mailer: Apple Mail (2.1993) X-Ovh-Tracer-Id: 3277213154274115645 X-Ovh-Remote: 193.248.240.88 (laubervilliers-656-1-116-88.w193-248.abo.wanadoo.fr) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejiedrgeejucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejiedrgeejucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Le 12 déc. 2014 à 16:44, Romain Perier a écrit : > > Hi, > > 2014-12-12 15:54 GMT+01:00 Julien CHAUVEAU > : >> This patch adds CLK_IGNORE_UNUSED flag to hclk_usb_peri, hclk_usbotg0 and hclk_usbotg1 >> because these clocks must remain enabled to use the USB controllers in host mode. >> >> This fixes a regression introduced by patch "clk: rockchip: disable unused clocks" >> https://lkml.kernel.org/g/1415092270-24932-1-git-send-email-kever.yang@rock-chips.com > > Could you refer the commit id instead ? something like "commit > ("title of the corresponding commit ») OK, I'll resubmit with commit 78eaf6095cc7 ("clk: rockchip: disable unused clocks"). > (and use scripts/checkpatch.pl > on your patch to be sure that the commit form is okay). > That’s already done: scripts/checkpatch.pl 0001-clk-rockchip-add-CLK_IGNORE_UNUSED-flag-to-fix-USB-H.patch total: 0 errors, 0 warnings, 30 lines checked > > I confirm the regression. > > Romain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/