Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030380AbaLMLdM (ORCPT ); Sat, 13 Dec 2014 06:33:12 -0500 Received: from smtp-out-084.synserver.de ([212.40.185.84]:1066 "EHLO smtp-out-084.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030331AbaLMLdJ (ORCPT ); Sat, 13 Dec 2014 06:33:09 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 12056 Message-ID: <548C23C0.8000701@metafoo.de> Date: Sat, 13 Dec 2014 12:32:16 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Hartmut Knaack , Nikolaus Schulz , Jonathan Cameron , Peter Meerwald , Grant Likely , Rob Herring , Michael Welling , Philippe Reynes , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org CC: Alban Bedel Subject: Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554 References: <1416858614-32265-1-git-send-email-nikolaus.schulz@avionic-design.de> <1416858614-32265-2-git-send-email-nikolaus.schulz@avionic-design.de> <5482EA33.7020305@gmx.de> In-Reply-To: <5482EA33.7020305@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2014 12:36 PM, Hartmut Knaack wrote: [...] >> +static int dac8554_read_raw(struct iio_dev *indio_dev, >> + struct iio_chan_spec const *chan, >> + int *val, >> + int *val2, >> + long m) > Commonly, m is called mask (like you do in _write_raw). We should call it info in new driver. It used to be a mask, but that was a long long time ago. [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/