Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754354AbaLMXMP (ORCPT ); Sat, 13 Dec 2014 18:12:15 -0500 Received: from mail-vc0-f176.google.com ([209.85.220.176]:54593 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbaLMXMM (ORCPT ); Sat, 13 Dec 2014 18:12:12 -0500 MIME-Version: 1.0 In-Reply-To: <548BE99E.2000409@ti.com> References: <1418396413-27937-1-git-send-email-lyz@rock-chips.com> <1418396866-32625-1-git-send-email-lyz@rock-chips.com> <548BE99E.2000409@ti.com> Date: Sat, 13 Dec 2014 15:12:10 -0800 X-Google-Sender-Auth: 4OUm-u-wOfq8kPmmwizwLPpCHTk Message-ID: Subject: Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY From: Doug Anderson To: Kishon Vijay Abraham I Cc: Yunzhi Li , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Grant Likely , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , jwerner@chromium.org, Olof Johansson , Tao Huang , Chris , Eddie Cai Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Dec 12, 2014 at 11:24 PM, Kishon Vijay Abraham I wrote: > hi, > > On Saturday 13 December 2014 05:49 AM, Doug Anderson wrote: >> Yunzhi, >> >> On Fri, Dec 12, 2014 at 7:07 AM, Yunzhi Li wrote: >>> This patch to add a generic PHY driver for ROCKCHIP usb PHYs, >>> currently this driver can support RK3288. The RK3288 SoC have >>> three independent USB PHY IPs which are all configured through a >>> set of registers located in the GRF (general register files) >>> module. >>> >>> Signed-off-by: Yunzhi Li >>> >>> --- >>> >>> Changes in v7: >>> - Accept Kishon's comments to use phandle args to find a phy >>> struct directly and get rid of using a custom of_xlate >>> function. >> >> I'm going to assume you didn't test this version, since it doesn't >> work for me. At suspend time power is high and my printouts in the >> powerup/powerdown code aren't called... >> >> >>> + for_each_available_child_of_node(dev->of_node, child) { >>> + rk_phy = devm_kzalloc(dev, sizeof(*rk_phy), GFP_KERNEL); >>> + if (!rk_phy) >>> + return -ENOMEM; >>> + >>> + if (of_property_read_u32(child, "reg", ®_offset)) { >>> + dev_err(dev, "missing reg property in node %s\n", >>> + child->name); >>> + return -EINVAL; >>> + } >>> + >>> + rk_phy->reg_offset = reg_offset; >>> + rk_phy->reg_base = grf; >>> + >>> + rk_phy->clk = of_clk_get_by_name(child, "phyclk"); >>> + if (IS_ERR(rk_phy->clk)) >>> + rk_phy->clk = NULL; >>> + >>> + rk_phy->phy = devm_phy_create(dev, child, &ops); >>> + if (IS_ERR(rk_phy->phy)) { >>> + dev_err(dev, "failed to create PHY\n"); >>> + return PTR_ERR(rk_phy->phy); >>> + } >>> + phy_set_drvdata(rk_phy->phy, rk_phy); >>> + } >>> + >>> + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); >> >> I think your bug is here. I think you now need to register 3 phy >> providers, not just one. > > No there should be only one phy provider. It means the bug is elsewhere. Ah. That's what I get for testing on a backported kernel. I bet it's because I'm missing: 2a4c370 phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node Hrm, that made things better, but I still only got one printout when I expected 3 (one for each user of the PHY). I bet there are more picks I need then... :-/ Ah, yup. When I pick the whole load of PHY related stuff then I get all 3. :) I'll do more testing when I have more time and post up a Tested-by, then... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/