Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750825AbaLNRvQ (ORCPT ); Sun, 14 Dec 2014 12:51:16 -0500 Received: from mail-la0-f42.google.com ([209.85.215.42]:58805 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbaLNRvN (ORCPT ); Sun, 14 Dec 2014 12:51:13 -0500 MIME-Version: 1.0 In-Reply-To: References: <1418081057-25283-1-git-send-email-george.mccollister@gmail.com> <20141210130412.GJ14346@localhost> Date: Sun, 14 Dec 2014 11:51:11 -0600 Message-ID: Subject: Re: [PATCH] USB: serial: add nt124 usb to serial driver From: George McCollister To: Johan Hovold Cc: linux-usb@vger.kernel.org, open list , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan, While working on the tx_empty changes you suggested it occurred to me that it might not be obvious to others that the firmware doesn't send a packet with the NT124_CTRL_TXEMPTY flag cleared when it begins transmitting. The practical implication is that if the driver sets tx_empty = true when it sees NT124_CTRL_TXEMPTY, tx_empty must be reset to false somewhere when more data is transmitted. Perhaps I could add prepare_write_buffer and do it in there before calling usb_serial_generic_prepare_write_buffer(). Does that sound acceptable? If so I'll also initialize tx_empty = true in nt124_port_probe. Regards, George -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/