Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494AbaLOKAs (ORCPT ); Mon, 15 Dec 2014 05:00:48 -0500 Received: from mail.emea.novell.com ([130.57.118.101]:42302 "EHLO mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbaLOKAq convert rfc822-to-8bit (ORCPT ); Mon, 15 Dec 2014 05:00:46 -0500 Message-Id: <548EBF58020000780004F7E7@mail.emea.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.0.1 Date: Mon, 15 Dec 2014 10:00:40 +0000 From: "Jan Beulich" To: "Boris Ostrovsky" Cc: , , , "xen-devel" , , , "Juergen Gross" , , , , Subject: Re: [Xen-devel] [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols References: <1418321065-10212-1-git-send-email-jgross@suse.com> <1418321065-10212-2-git-send-email-jgross@suse.com> <548B70B3.7030807@oracle.com> In-Reply-To: <548B70B3.7030807@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 12.12.14 at 23:48, wrote: > On 12/11/2014 01:04 PM, Juergen Gross wrote: >> diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh >> new file mode 100644 >> index 0000000..e6447b7 >> --- /dev/null >> +++ b/scripts/xen-hypercalls.sh >> @@ -0,0 +1,11 @@ >> +#!/bin/sh >> +out="$1" >> +shift >> +in="$@" >> + >> +for i in $in; do >> + eval $CPP $LINUXINCLUDE -dD -imacros "$i" -x c /dev/null >> +done | \ >> +awk '$1 == "#define" && $2 ~ /__HYPERVISOR_[a-z][a-z_0-9]*/ { v[$3] = $2 } >> + END {for (i in v) if (!(v[i] in v)) >> + print "HYPERCALL("substr(v[i], 14)")"}' | sort -u >$out > > Why do you 'sort -u'? Do you expect multiple definitions of the same > hypercall? For upstream I think this could be dropped; the original version needs this as the classic tree sticks more closely to the original xen.h (which has a couple of backward compatibility defines which would get in the way). Otoh it does no harm afaict... Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/