Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbaLOKk6 (ORCPT ); Mon, 15 Dec 2014 05:40:58 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:59351 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750737AbaLOKky (ORCPT ); Mon, 15 Dec 2014 05:40:54 -0500 Date: Mon, 15 Dec 2014 10:40:29 +0000 From: Russell King - ARM Linux To: Yakir Yang Cc: Heiko Stuebner , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Philipp Zabel , Zubair.Kakakhel@imgtec.com, Fabio Estevam , Shawn Guo , dri-devel@lists.freedesktop.org, Daniel Kurtz , Sonny Rao , Dylan Reid , Xu Jianqun , =?utf-8?B?U3Tvv73vv71waGFuZQ==?= Marchesin , Lars-Peter Clausen , Brian Austin , Bard Liao , Max Filippov , Oder Chiou , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, Arnd Bergmann , David Airlie , Sean Cross , Grant Likely , Greg Kroah-Hartman , Ben Zhang , Liam Girdwood , Jaroslav Kysela , Mark Brown , Takashi Iwai , Jyri Sarha Subject: Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio Message-ID: <20141215104029.GE11285@n2100.arm.linux.org.uk> References: <1418609494-15820-1-git-send-email-ykk@rock-chips.com> <1418612114-19692-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418612114-19692-1-git-send-email-ykk@rock-chips.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 15, 2014 at 10:55:14AM +0800, Yakir Yang wrote: > Required properties: > - compatible: platform specific > - cpu-of-node: the device node of cpu_dai > - codec-name: the dw-hdmi codec's device name > - codec-dai-name: the dw-hdmi codec's dai name This is not actually a separate physical device from the main dw-hdmi device. What you are doing is merely describing the Linux kernel internals in DT, which is not what DT is supposed to be about. DT is supposed to describe the hardware in an operating system independent manner. Including details like this (because ASoC needs a separate DT node) is the wrong approach. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/