Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751078AbaLOKur (ORCPT ); Mon, 15 Dec 2014 05:50:47 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:48578 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbaLOKup (ORCPT ); Mon, 15 Dec 2014 05:50:45 -0500 MIME-Version: 1.0 In-Reply-To: <548E1279.8050907@gmx.de> References: <1417613513-28285-1-git-send-email-daniel.baluta@intel.com> <1417613513-28285-2-git-send-email-daniel.baluta@intel.com> <548E1279.8050907@gmx.de> Date: Mon, 15 Dec 2014 12:50:43 +0200 X-Google-Sender-Auth: TeiROK4Ro_cyA14wCtPY4AEycVk Message-ID: Subject: Re: [PATCH v4 1/6] iio: imu: Add support for Kionix KMX61 sensor From: Daniel Baluta To: Hartmut Knaack Cc: Daniel Baluta , Jonathan Cameron , Peter Meerwald , Srinivas Pandruvada , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 15, 2014 at 12:43 AM, Hartmut Knaack wrote: > Daniel Baluta schrieb am 03.12.2014 um 14:31: >> Minimal implementation for KMX61 6-axis accelerometer/magnetometer. It exports >> raw accel/magn readings together with scale and sampling frequency. >> >> This driver uses two IIO devices one for accelerometer and one for magnetometer. >> > Hi Daniel, > I think you dropped slightly too much code. In kmx61_set_odr() you stored the set > odr bits in data->odr_bits previously, but now it's gone. But kmx61_get_odr() > accesses data->odr_bits, which now remains in the state from driver initialization. > Other than that, it's looking good. Hi Hartmut, Good catch. I will send a patch asap. Thanks for feedback! Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/