Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754539AbaLOPVN (ORCPT ); Mon, 15 Dec 2014 10:21:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39033 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710AbaLOPVH (ORCPT ); Mon, 15 Dec 2014 10:21:07 -0500 Message-ID: <548EFA9F.4080208@redhat.com> Date: Mon, 15 Dec 2014 16:13:35 +0100 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Vishnu Patekar CC: "linux-input@vger.kernel.org" , "maxime.ripard@free-electrons.com" , Dmitry Torokhov , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , "linux@arm.linux.org.uk" , Grant Likely , "benh@kernel.crashing.org" , "msalter@redhat.com" , "ralf@linux-mips.org" , "jdelvare@suse.de" Subject: Re: [PATCHv3 0/5] ARM:sunxi:ps2 Added support for A10/A20 ps2 controller. References: <1418408748-9797-1-git-send-email-vishnupatekar0510@gmail.com> <548C1E7D.1000005@redhat.com> <548D5207.8030004@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 15-12-14 15:13, Vishnu Patekar wrote: > Hi, > > On Sun, Dec 14, 2014 at 2:31 PM, Hans de Goede wrote: >> Hi, >> >> On 13-12-14 21:01, Vishnu Patekar wrote: >>> >>> Hello Hans, >>> Please find my comments inlined. >>> >>> On 12/13/14, Hans de Goede wrote: >>>> >>>> Hi VishnuPatekar, >>>> >>>> The patch mangling for this set seems to have gone a bit wrong I'm afraid >>> >>> >>> No, this time I've corrected it. Infact, last version of patch did not >>> used the status bit error macros. >>> >>>> a lot of the patches have my fixup commit messages (which should have >>>> disappeared when squashing in the patches), please replace those by >>>> proper >>>> commit messages describing what the patch actually does. >>> >>> Yes, [PATCHv3 3/5] uses fixup. I'll correct it. >>>> >>>> >>>> Also the adding of the commented nodes for the lime2 seems to be gone >>>> entirely >>>> from the set, instead now only a comment about the conflict with the hdmi >>>> pins is added, but it is above the i2c node instead of above a ps2 node. >>>> >>> Maxime's suggested that we should not add commented nodes specially >>> when its trivial to apply. And just note saying ps20 pins conflict >>> with HDMI. >> >> >> Ah, I see. >> >>> Should I remove the this comment as well? >>> Or >>> Put this note in start of DTS file? >> >> >> The comment should be added to where the pinctrl bits are, not to the lime2 >> file, ps0 will conflict with hdmi on all boards. > > Well, In that case,PS2_0 pins conflicts with HDMI, PS2_1 pins > conflicts with LCD. Every pin has multiplexing. Almost every A10 board has a hdmi connector, and only the hdmi ddc pins are multiplexed, so this is sort of special, but yes if we do not have the commented nodes in the dts file, then this comment can be dropped too I guess. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/