Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752676AbaLOPmK (ORCPT ); Mon, 15 Dec 2014 10:42:10 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:35868 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbaLOPmI (ORCPT ); Mon, 15 Dec 2014 10:42:08 -0500 Date: Mon, 15 Dec 2014 07:42:03 -0800 From: Omar Sandoval To: Trond Myklebust Cc: Alexander Viro , Andrew Morton , Christoph Hellwig , David Sterba , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] nfs: follow direct I/O write locking convention Message-ID: <20141215154203.GA20161@mew> References: <7561c096c7de603ac39fcfcff7bd2ec80589cae1.1418618044.git.osandov@osandov.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 15, 2014 at 07:49:20AM -0500, Trond Myklebust wrote: > On Mon, Dec 15, 2014 at 12:26 AM, Omar Sandoval wrote: > > The generic callers of direct_IO lock i_mutex before doing a write. NFS > > doesn't use the generic write code, so it doesn't follow this > > convention. This is now a problem because the interface introduced for > > swap-over-NFS calls direct_IO for a write without holding i_mutex, but > > other implementations of direct_IO will expect to have it locked. > > I really don't care much about swap-over-NFS performance; that's a > niche usage at best. I _do_ care about O_DIRECT performance, and the > ability to run multiple WRITE calls in parallel. > > IOW: Patch NACKed... Please find another solution. > > Trond So the patch formatting doesn't make it completely clear what's going on here, but here's what the original nfs_file_direct_write code did: - called with i_mutex unlocked - collects stats and does some generic checks - locks i_mutex - syncs the mapping, schedules the write - unlocks i_mutex - waits for the write to complete if synchronous After this patch, nfs_file_direct_write works like: - called with i_mutex locked - collects stats and does some generic checks - syncs the mapping, schedules the write - drops i_mutex - waits for the write to complete if synchronous - picks i_mutex back up There's an extra lock and unlock as a result and a slightly longer critical section, but we drop i_mutex to wait for the write, so multiple writes still work in parallel. -- Omar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/