Message-ID: <1418661543.2674.17.camel@perches.com>
Subject: Re: [PATCH] Staging: rtl8712: removed an unnecessary else statement
From: Joe Perches <joe@perches.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net
Date: Mon, 15 Dec 2014 08:39:03 -0800
In-Reply-To: <1418657154-10481-1-git-send-email-karthik.188@gmail.com>
References: <1418657154-10481-1-git-send-email-karthik.188@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-12-15 at 20:55 +0530, Karthik Nayak wrote:
> As per checkpatch warning, removed an unnecessary else statement
> proceeding an if statement with a return.

This is not a correct change.
The checkpatch message said "generally".
You still have to verify the code.

> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> index cd8b444..800b2b3 100644
> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -496,8 +496,7 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
>  			plist = plist->next;
>  		else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
>  			return false;
> -		else
> -			break;
> +		break;


It's not the same logic.
It would be if the code was:

	while (end_of_queue_search(phead, plist) == false) {
		pnextrframe = LIST_CONTAINOR(plist, union recv_frame, u);
		pnextattrib = &pnextrframe->u.hdr.attrib;
		if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) {
			plist = plist->next;
			continue;
		} else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num)) {
			return false;
		}
		break;
	}

But that's not necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/