Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750840AbaLORLi (ORCPT ); Mon, 15 Dec 2014 12:11:38 -0500 Received: from smtprelay01.ispgateway.de ([80.67.29.23]:45456 "EHLO smtprelay01.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbaLORLg (ORCPT ); Mon, 15 Dec 2014 12:11:36 -0500 References: <548F139D.4090901@infradead.org> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Peter Feuerer To: Randy Dunlap Cc: Platform Driver , Darren Hart , LKML Subject: Re: [PATCH -next] platform/x86/acerhdf: still depends on THERMAL Date: Mon, 15 Dec 2014 18:10:14 +0100 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Df-Sender: NDA0MDk0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy Dunlap writes: > From: Randy Dunlap > > acerhdf uses thermal interfaces so it should depend on THERMAL. > It also should not select a thermal driver without checking that > THERMAL is enabled. > > This fixes the following build errors when THERMAL=m and > ACERHDF=y. > > drivers/built-in.o: In function `acerhdf_set_mode': > acerhdf.c:(.text+0x3e02e1): undefined reference to `thermal_zone_device_update' > drivers/built-in.o: In function `acerhdf_unbind': > acerhdf.c:(.text+0x3e052d): undefined reference to `thermal_zone_unbind_cooling_device' > drivers/built-in.o: In function `acerhdf_bind': > acerhdf.c:(.text+0x3e0593): undefined reference to `thermal_zone_bind_cooling_device' > drivers/built-in.o: In function `acerhdf_init': > acerhdf.c:(.init.text+0x1c2f5): undefined reference to `thermal_cooling_device_register' > acerhdf.c:(.init.text+0x1c360): undefined reference to `thermal_zone_device_register' > drivers/built-in.o: In function `acerhdf_unregister_thermal': > acerhdf.c:(.text.unlikely+0x3c67): undefined reference to `thermal_cooling_device_unregister' > acerhdf.c:(.text.unlikely+0x3c91): undefined reference to `thermal_zone_device_unregister' > > Signed-off-by: Randy Dunlap > Cc: Peter Feuerer > Cc: Darren Hart > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20141215.orig/drivers/platform/x86/Kconfig > +++ linux-next-20141215/drivers/platform/x86/Kconfig > @@ -38,8 +38,8 @@ config ACER_WMI > > config ACERHDF > tristate "Acer Aspire One temperature and fan driver" > + depends on ACPI && THERMAL > select THERMAL_GOV_BANG_BANG > - depends on ACPI > ---help--- > This is a driver for Acer Aspire One netbooks. It allows to access > the temperature sensor and to control the fan. Acked-by: Peter Feuerer Thanks. --peter; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/