Message-ID: <1418664431.2674.19.camel@perches.com>
Subject: Re: [PATCH] Staging: rtl8712: removed an unnecessary else statement
From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Karthik Nayak <karthik.188@gmail.com>, trivial@kernel.org,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Date: Mon, 15 Dec 2014 09:27:11 -0800
In-Reply-To: <548F1686.4080507@lwfinger.net>
References: <1418657154-10481-1-git-send-email-karthik.188@gmail.com>
	 <1418661543.2674.17.camel@perches.com> <548F1686.4080507@lwfinger.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-12-15 at 11:12 -0600, Larry Finger wrote:
> On 12/15/2014 10:39 AM, Joe Perches wrote:
> > On Mon, 2014-12-15 at 20:55 +0530, Karthik Nayak wrote:
> >> As per checkpatch warning, removed an unnecessary else statement
> >> proceeding an if statement with a return.
> >
> > This is not a correct change.
> > The checkpatch message said "generally".
> > You still have to verify the code.
[]
> Perhaps checkpatch should ignore setting this warning when there is an "else if" 
> in the flow.

In a patch, that's not possible as the
context may not show the flow.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/