Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751447AbaLOSPl (ORCPT ); Mon, 15 Dec 2014 13:15:41 -0500 Received: from mail-vc0-f172.google.com ([209.85.220.172]:35409 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbaLOSPi (ORCPT ); Mon, 15 Dec 2014 13:15:38 -0500 MIME-Version: 1.0 In-Reply-To: <1418397422-17249-1-git-send-email-lyz@rock-chips.com> References: <1418396413-27937-1-git-send-email-lyz@rock-chips.com> <1418397422-17249-1-git-send-email-lyz@rock-chips.com> Date: Mon, 15 Dec 2014 10:15:37 -0800 X-Google-Sender-Auth: RT-afMU6kSaqYFS1pTyHie-IAZE Message-ID: Subject: Re: [PATCH v7 5/5] ARM: dts: rockchip: Enable usb PHY on rk3288-evb board From: Doug Anderson To: Yunzhi Li Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , jwerner@chromium.org, Olof Johansson , Tao Huang , Chris , Eddie Cai Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yunzhi, On Fri, Dec 12, 2014 at 7:17 AM, Yunzhi Li wrote: > Enable usb PHY for all usb ports on rk3288-evb. > > Signed-off-by: Yunzhi Li > > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > > arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) I have tested a similar change on rk3288-pinky (on a 3.14 tree with backports). There I can confirm that this properly gets us into low power at suspend time. I have not tested on EVB itself though, so leaving off my tested tag. This does look reasonable to me, though: Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/