Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750859AbaLOTQQ (ORCPT ); Mon, 15 Dec 2014 14:16:16 -0500 Received: from mail-qc0-f178.google.com ([209.85.216.178]:38970 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbaLOTQO (ORCPT ); Mon, 15 Dec 2014 14:16:14 -0500 MIME-Version: 1.0 In-Reply-To: <20141215163232.GA21962@lerouge> References: <1418610272-21518-1-git-send-email-fweisbec@gmail.com> <1418610272-21518-3-git-send-email-fweisbec@gmail.com> <20141215163232.GA21962@lerouge> Date: Mon, 15 Dec 2014 11:16:13 -0800 X-Google-Sender-Auth: BrgypbGZ3jaHdM2-P0z_8uShy7M Message-ID: Subject: Re: [PATCH 2/2] sched: Pull resched loop to __schedule() callers From: Linus Torvalds To: Frederic Weisbecker Cc: Ingo Molnar , LKML , Peter Zijlstra Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 15, 2014 at 8:32 AM, Frederic Weisbecker wrote: > > But it may have an impact on some context checkers that rely on in_atomic*() > which ignore the PREEMPT_ACTIVE value. It shouldn't ignore that though but I > guess it's a hack for some specific situation. I think we should remove it. The only reason for it is the scheduler itself, which used to have the in_atomic() check (ok, still has, it's just called "in_atomic_preempt_off()"). But yes, if we keep the "mask off PREEMPT_ACTIVE" in in_atomic(), then we do need to update the counts with "PREEMPT_ACTIVE+1" instead. Or something like that. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/