Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbaLPFnO (ORCPT ); Tue, 16 Dec 2014 00:43:14 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:37741 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbaLPFnM (ORCPT ); Tue, 16 Dec 2014 00:43:12 -0500 MIME-Version: 1.0 In-Reply-To: References: <20141216001058.GA31286@dtor-ws> Date: Mon, 15 Dec 2014 21:43:11 -0800 Message-ID: Subject: Re: [PATCH] cpufreq-dt: defer probing if OPP table is not ready From: Dmitry Torokhov To: Viresh Kumar Cc: Dmitry Torokhov , "Rafael J. Wysocki" , Lucas Stach , Thomas Petazzoni , Geert Uytterhoeven , Stefan Wahren , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 15, 2014 at 9:38 PM, Viresh Kumar wrote: > On 16 December 2014 at 11:02, Dmitry Torokhov wrote: >> Yes we will. Which simply means that this WARN is stupid. We also will >> hit it if there is no opp table and the allocation below fails; or if >> it succeeds then dev_pm_opp_init_cpufreq_table() will fail and we'll >> hit this code path again. >> >> We should either drop that WARN() or handle -ENODEV there properly. > > Yeah, we should drop it. Its just too hard for such cases. You will take care > of that in your series? > Yes, I'll address other comments and resubmit. > For your patch: > > Reviewed-by: Viresh Kumar Thanks! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/