Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750936AbaLPNz1 (ORCPT ); Tue, 16 Dec 2014 08:55:27 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:38721 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbaLPNz0 (ORCPT ); Tue, 16 Dec 2014 08:55:26 -0500 Date: Tue, 16 Dec 2014 16:54:59 +0300 From: Dan Carpenter To: Chris Rorvick Cc: "devel@driverdev.osuosl.org" , "Drokin, Oleg" , "Dilger, Andreas" , Rickard Strandqvist , James Simmons , Greg Kroah-Hartman , Greg Donald , "linux-kernel@vger.kernel.org" , Fabian Frederick , Julia Lawall , Andriy Skulysh , "HPDD-discuss@ml01.01.org" , "Hammond, John" Subject: Re: [PATCH] drivers: staging: lustre: Use mult if units not specified Message-ID: <20141216135459.GJ4856@mwanda> References: <1418708509-18196-1-git-send-email-chris@rorvick.com> <20141216094109.GH4856@mwanda> <20141216113509.GI4856@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 16, 2014 at 06:53:19AM -0600, Chris Rorvick wrote: > On Tue, Dec 16, 2014 at 5:35 AM, Dan Carpenter wrote: > > On Tue, Dec 16, 2014 at 11:14:35AM +0000, Dilger, Andreas wrote: > > > > > > Sorry, that isn't right. Chris' patch is actually doing the right thing > > > to check for units > 1. > > > > It's not right because it discards the negative. > > I don't think this patch introduces a bug. If anything, it was already > there. The original code may be totally buggy. Who knows? Why are we passing negative numbers here anyway instead of just returning -EINVAL? But the new code is also buggy and not consistent with itself. In the original code if the user data is "-1k" or "-1024" that was treated the same. In the new code, "-1k" means negative 1024 because the user supplies units but "-1024" means positive 1024 because there are no units given. > > > The proposed change above discards "mult" > > > entirely, which breaks the users of this function that are not in this > > > file (e.g. osc_cached_mb_seq_write() or ll_max_cached_mb_seq_write()) > > > that have tunables in units of MB by default, but can also use parameters > > > with units like "4.5G" for convenience. > > > > I think you are confusing lprocfs_write_frac_helper() and > > lprocfs_write_frac_u64_helper(). There is only one caller for this > > function. > > By this logic, lprocfs_write_frac_u64_helper() should just be removed > and it's code should be folded into lprocfs_write_u64_helper(), no? > There are vast swathes of lustre code which need to be deleted but I haven't looked at this one. Probably. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/