Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751151AbaLPN4p (ORCPT ); Tue, 16 Dec 2014 08:56:45 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:45353 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbaLPN4n (ORCPT ); Tue, 16 Dec 2014 08:56:43 -0500 Date: Tue, 16 Dec 2014 05:56:39 -0800 From: Jeremiah Mahler To: Dudley Du Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se, bleung@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v15 09/12] input: cyapa: add gen5 trackpad device firmware update function support Message-ID: <20141216135639.GA1238@hudson.localdomain> Mail-Followup-To: Jeremiah Mahler , Dudley Du , dmitry.torokhov@gmail.com, rydberg@euromail.se, bleung@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <1418624603-19054-1-git-send-email-dudley.dulixin@gmail.com> <1418624603-19054-10-git-send-email-dudley.dulixin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418624603-19054-10-git-send-email-dudley.dulixin@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dudley, On Mon, Dec 15, 2014 at 02:23:20PM +0800, Dudley Du wrote: > Add firmware image update function supported for gen5 trackpad device, > it can be used through sysfs update_fw interface. > TEST=test on Chromebooks. > > Signed-off-by: Dudley Du > --- > drivers/input/mouse/Kconfig | 1 + > drivers/input/mouse/cyapa_gen5.c | 292 ++++++++++++++++++++++++++++++++++++++- > 2 files changed, 292 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig > index d8b46b0..728490e 100644 > --- a/drivers/input/mouse/Kconfig > +++ b/drivers/input/mouse/Kconfig > @@ -206,6 +206,7 @@ config MOUSE_BCM5974 > config MOUSE_CYAPA > tristate "Cypress APA I2C Trackpad support" > depends on I2C > + select CRC_ITU_T > help Just found out that if I2C_DESIGNWARE_PCI isn't enabled the touchpad won't work. Verify this on your machines. Then perhaps add a depends for I2C_DESIGNWARE_PCI instead of I2C since it would include the former. [...] -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/