Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527AbaLPOy0 (ORCPT ); Tue, 16 Dec 2014 09:54:26 -0500 Received: from mail-qg0-f50.google.com ([209.85.192.50]:42785 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbaLPOyY (ORCPT ); Tue, 16 Dec 2014 09:54:24 -0500 MIME-Version: 1.0 In-Reply-To: <1418691016-30681-4-git-send-email-peter@lekensteyn.nl> References: <1418691016-30681-1-git-send-email-peter@lekensteyn.nl> <1418691016-30681-4-git-send-email-peter@lekensteyn.nl> Date: Tue, 16 Dec 2014 09:54:23 -0500 Message-ID: Subject: Re: [PATCH 3/3] HID: logitech-hidpp: avoid unintended fall-through From: Benjamin Tissoires To: Peter Wu Cc: Jiri Kosina , Benjamin Tissoires , Nestor Lopez Casado , linux-input , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 15, 2014 at 7:50 PM, Peter Wu wrote: > Add a return to avoid a fall-through. Introduced in commit > 57ac86cf52e903d9e3e0f12b34c814cce6b65550 ("HID: logitech-hidpp: add > support of the first Logitech Wireless Touchpad"). > > Signed-off-by: Peter Wu > --- This one is reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/hid-logitech-hidpp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 2315358..09eee17 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -811,6 +811,7 @@ static int wtp_raw_event(struct hid_device *hdev, u8 *data, int size) > input_event(wd->input, EV_KEY, BTN_RIGHT, > !!(data[1] & 0x02)); > input_sync(wd->input); > + return 0; > } else { > if (size < 21) > return 1; > -- > 2.1.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/