Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbaLPPPr (ORCPT ); Tue, 16 Dec 2014 10:15:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbaLPPPq (ORCPT ); Tue, 16 Dec 2014 10:15:46 -0500 Date: Tue, 16 Dec 2014 16:15:21 +0100 From: Jesper Dangaard Brouer To: Christoph Lameter Cc: Joonsoo Kim , Andrey Ryabinin , akpm@linuxfoundation.org, rostedt@goodmis.org, LKML , Thomas Gleixner , "linux-mm@kvack.org" , Pekka Enberg , brouer@redhat.com Subject: Re: [PATCH 3/7] slub: Do not use c->page on free Message-ID: <20141216161521.1f72e102@redhat.com> In-Reply-To: References: <20141210163017.092096069@linux.com> <20141210163033.717707217@linux.com> <20141215080338.GE4898@js1304-P5Q-DELUXE> <20141216024210.GB23270@js1304-P5Q-DELUXE> <20141216082555.GA6088@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Dec 2014 08:53:08 -0600 (CST) Christoph Lameter wrote: > On Tue, 16 Dec 2014, Joonsoo Kim wrote: > > > > Like this: > > > > > > return d > 0 && d < page->objects * s->size; > > > > > > > Yes! That's what I'm looking for. > > Christoph, how about above change? > > Ok but now there is a multiplication in the fast path. Could we pre-calculate the value (page->objects * s->size) and e.g store it in struct kmem_cache, thus saving the imul ? -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/