Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbaLPVCE (ORCPT ); Tue, 16 Dec 2014 16:02:04 -0500 Received: from mail-vc0-f177.google.com ([209.85.220.177]:47139 "EHLO mail-vc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbaLPVCC (ORCPT ); Tue, 16 Dec 2014 16:02:02 -0500 MIME-Version: 1.0 In-Reply-To: <1415863357-15680-1-git-send-email-kever.yang@rock-chips.com> References: <1415863357-15680-1-git-send-email-kever.yang@rock-chips.com> Date: Tue, 16 Dec 2014 13:02:01 -0800 X-Google-Sender-Auth: sVyLIcHrLewOkR8oMy3lfqy-3LU Message-ID: Subject: Re: [PATCH 1/2] clk: rockchip: add clock ID for usbphy480m_src From: Doug Anderson To: Kever Yang Cc: Heiko Stuebner , Mike Turquette , Sonny Rao , Addy Ke , Eddie Cai , =?UTF-8?B?5oi05YWL6ZyWIChKYWNrKQ==?= , Tao Huang , "open list:ARM/Rockchip SoC..." , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mark yao , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kever, On Wed, Nov 12, 2014 at 11:22 PM, Kever Yang wrote: > There are 3 different parent clock from different usbphy, > all of them are fixed 480MHz, it is not able to auto select > by clock core to the 2nd and the 3rd parent. > For different use case for different board, we may need to > select different usbphy clock out as parent manually. > > Add the clock ID for it so that we can use in dts. > > Signed-off-by: Kever Yang > --- > > include/dt-bindings/clock/rk3288-cru.h | 1 + > 1 file changed, 1 insertion(+) Aside from clock ID collisions that Heiko can fixup, this looks good to me. Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/