Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbaLPXSP (ORCPT ); Tue, 16 Dec 2014 18:18:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59594 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbaLPXSP (ORCPT ); Tue, 16 Dec 2014 18:18:15 -0500 Date: Wed, 17 Dec 2014 01:18:02 +0200 From: "Michael S. Tsirkin" To: Herbert Xu Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 8/9] virtio_pci: split out legacy device support Message-ID: <20141216231802.GB19694@redhat.com> References: <1418043812-25753-9-git-send-email-mst@redhat.com> <20141216210309.GA32071@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141216210309.GA32071@gondor.apana.org.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 17, 2014 at 08:03:10AM +1100, Herbert Xu wrote: > Michael S. Tsirkin wrote: > > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > > Expose common code APIs in virtio_pci.h > > > > Signed-off-by: Michael S. Tsirkin > > This breaks virtio_pci because you deleted the licence from it. > > -- >8 -- > Subject: virtio_pci: Restore module licence and other attributes > > When the virtio_pci driver was moved into virtio_pci_legacy.c the > module licence and other attributes went AWOL. This patch restores > them. > > Signed-off-by: Herbert Xu I applied this with a minor tweak, and pushed to linux-next. Unfortunately it's very late here, so I can't test properly and send pull request today, but will try to do tomorrow. The tree with a fix is here: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git for_linus > diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c > index 2588252..6b100e3 100644 > --- a/drivers/virtio/virtio_pci_legacy.c > +++ b/drivers/virtio/virtio_pci_legacy.c > @@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = { > }; > > module_pci_driver(virtio_pci_driver); > + > +MODULE_AUTHOR("Anthony Liguori "); > +MODULE_DESCRIPTION("virtio-pci"); > +MODULE_LICENSE("GPL"); > +MODULE_VERSION("1"); > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/