Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbaLQKOk (ORCPT ); Wed, 17 Dec 2014 05:14:40 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:52606 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbaLQKOj (ORCPT ); Wed, 17 Dec 2014 05:14:39 -0500 Date: Wed, 17 Dec 2014 02:14:34 -0800 From: Jeremiah Mahler To: Dudley Du Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se, bleung@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 01/12] input: cyapa: re-design driver to support Message-ID: <20141217101434.GA2155@newt.localdomain> Mail-Followup-To: Jeremiah Mahler , Dudley Du , dmitry.torokhov@gmail.com, rydberg@euromail.se, bleung@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dudley, On Wed, Dec 17, 2014 at 05:55:37PM +0800, Dudley Du wrote: > In order to support multiple different chipsets and communication protocols > trackpad devices in one cyapa driver, the new cyapa driver is re-designed > with one cyapa driver core and multiple device specific functions component. > The cyapa driver core is contained in this patch, it supplies basic functions [...] > + > + .set_power_mode = cyapa_gen3_set_power_mode, > +}; > -- > 1.9.1 > Unfortunately this patch and the others do not apply. Patch failed at 0001 input: cyapa: re-design driver to support The copy of the patch that failed is found in: /home/jeri/linux-next/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". It looks like your mailer may have done some line wrapping that messed up the patches. ... - { CYAPA_SMBUS_BLK_HEAD, 16 }, -}; +static int cyapa_reinitialize(struct cyapa *cyapa); -static ssize_t cyapa_i2c_reg_read_block(struct cyapa *cyapa, u8 reg, size_t len, +/* Returns 0 on success, else negative errno on failure. */ +static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len, u8 *values) { - ... linux/Documentation/email-clients.txt has good information about these problems. -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/