Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751138AbaLQPi6 (ORCPT ); Wed, 17 Dec 2014 10:38:58 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:40277 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900AbaLQPiz (ORCPT ); Wed, 17 Dec 2014 10:38:55 -0500 MIME-Version: 1.0 In-Reply-To: <20141217064802.GA4971@hudson.localdomain> References: <1418624603-19054-1-git-send-email-dudley.dulixin@gmail.com> <1418624603-19054-10-git-send-email-dudley.dulixin@gmail.com> <20141216135639.GA1238@hudson.localdomain> <20141217064802.GA4971@hudson.localdomain> Date: Wed, 17 Dec 2014 07:38:55 -0800 X-Google-Sender-Auth: 6ewAKkd47t30oL_F8bBdOXPGE_E Message-ID: Subject: Re: [PATCH v15 09/12] input: cyapa: add gen5 trackpad device firmware update function support From: Benson Leung To: Jeremiah Mahler , Benson Leung , Dudley Du , Dmitry Torokhov , Henrik Rydberg , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 16, 2014 at 10:48 PM, Jeremiah Mahler wrote: > So DESIGNWARE_PCI isn't required for all devices. But if MOUSE_CYAPA is > enabled some devices won't work unless I2C_DESIGNWARE_PCI is enabled. I > wonder if MOUSE_CYAPA should be broken up in to separate working > configurations? MOUSE_CYAPA_GEN5, MOUSE_CYAPA_GEN3, ? Splitting into two configs doesn't help either. Currently, all Cypress devices available for Chromebooks are Gen 3. This includes the ARM Samsung Chromebook which doesn't use I2C_DESIGNWARE_PCI, and the C720/HP Chromebook 14/Dell Chromebook 11 which do require I2C_DESIGNWARE_PCI. The right thing to do would be to add the the I2C_DESIGNWARE_PCI depend for the CHROMEOS_LAPTOP config. The chromeos_laptop driver actually refers to I2C_DESIGNWARE_PCI by name, so it is appropriate there. -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/