Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbaLRLjj (ORCPT ); Thu, 18 Dec 2014 06:39:39 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:33190 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844AbaLRLji (ORCPT ); Thu, 18 Dec 2014 06:39:38 -0500 MIME-Version: 1.0 In-Reply-To: <20141218090053.68a0aad6@recife.lan> References: <1418873833-5084-1-git-send-email-zhang.chunyan@linaro.org> <1685288.Gd2P1eSoIW@wuerfel> <20141218090053.68a0aad6@recife.lan> Date: Thu, 18 Dec 2014 19:39:37 +0800 Message-ID: Subject: Re: [PATCH] media: rc: Replace timeval with ktime_t in imon.c From: Chunyan Zhang To: Mauro Carvalho Chehab Cc: Arnd Bergmann , david@hardeman.nu, uli-lirc@uli-eckhardt.de, hans.verkuil@cisco.com, julia.lawall@lip6.fr, Himangi Saraogi , Alexey Khoroshilov , joe@perches.com, John Stultz , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Lyra Zhang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 18, 2014 at 7:00 PM, Mauro Carvalho Chehab wrote: > Em Thu, 18 Dec 2014 17:38:14 +0800 > Chunyan Zhang escreveu: > >> On Thu, Dec 18, 2014 at 3:50 PM, Arnd Bergmann wrote: >> > On Thursday 18 December 2014 11:37:13 Chunyan Zhang wrote: >> >> This patch changes the 32-bit time type (timeval) to the 64-bit one >> >> (ktime_t), since 32-bit time types will break in the year 2038. >> >> >> >> I use ktime_t instead of all uses of timeval in imon.c >> >> >> >> This patch also changes do_gettimeofday() to ktime_get() accordingly, >> >> since ktime_get returns a ktime_t, but do_gettimeofday returns a >> >> struct timeval, and the other reason is that ktime_get() uses >> >> the monotonic clock. >> >> >> >> This patch use a new function which is provided by another patch listed below >> >> to get the millisecond time difference. >> > >> > The patch looks great. Just a few small details that could still be >> > improved: > > Yes, patch looks OK. After addressing the bits pointed by Arnd: > > Acked-by: Mauro Carvalho Chehab > > Feel free to merge via y2038 tree. > Ok, thank you, I'll send the updated patch-set soon. Chunyan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/