Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbaLRPU4 (ORCPT ); Thu, 18 Dec 2014 10:20:56 -0500 Received: from mga11.intel.com ([192.55.52.93]:28874 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbaLRPUy convert rfc822-to-8bit (ORCPT ); Thu, 18 Dec 2014 10:20:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,601,1413270000"; d="scan'208";a="639757030" From: "Zhang, Yang Z" To: "Wu, Feng" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "gleb@kernel.org" , "pbonzini@redhat.com" , "dwmw2@infradead.org" , "joro@8bytes.org" , "alex.williamson@redhat.com" , "jiang.liu@linux.intel.com" CC: "eric.auger@linaro.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "Wu, Feng" Subject: RE: [v3 12/26] KVM: Initialize VT-d Posted-Interrupts Descriptor Thread-Topic: [v3 12/26] KVM: Initialize VT-d Posted-Interrupts Descriptor Thread-Index: AQHQFiDtxb5SKKBrwUimVMToMZVzKZyVfTEA Date: Thu, 18 Dec 2014 15:19:40 +0000 Message-ID: References: <1418397300-10870-1-git-send-email-feng.wu@intel.com> <1418397300-10870-13-git-send-email-feng.wu@intel.com> In-Reply-To: <1418397300-10870-13-git-send-email-feng.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Feng Wu wrote on 2014-12-12: > This patch initializes the VT-d Posted-Interrupts Descriptor. > > Signed-off-by: Feng Wu > --- > arch/x86/kvm/vmx.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index > 0b1383e..66ca275 100644 --- a/arch/x86/kvm/vmx.c +++ > b/arch/x86/kvm/vmx.c @@ -45,6 +45,7 @@ > #include > #include > #include > +#include > > #include "trace.h" > @@ -4433,6 +4434,30 @@ static void ept_set_mmio_spte_mask(void) > kvm_mmu_set_mmio_spte_mask((0x3ull << 62) | 0x6ull); } > +static void pi_desc_init(struct vcpu_vmx *vmx) { > + unsigned int dest; > + > + if (!irq_remapping_cap(IRQ_POSTING_CAP)) > + return; > + > + /* > + * Initialize Posted-Interrupt Descriptor > + */ > + > + pi_clear_sn(&vmx->pi_desc); > + vmx->pi_desc.nv = POSTED_INTR_VECTOR; Here. > + > + /* Physical mode for Notificaiton Event */ > + vmx->pi_desc.ndm = 0; And from here.. > + dest = cpu_physical_id(vmx->vcpu.cpu); > + > + if (x2apic_enabled()) > + vmx->pi_desc.ndst = dest; > + else > + vmx->pi_desc.ndst = (dest << 8) & 0xFF00; } > + ..to here are useless. The right place to update PI descriptor is where vcpu got loaded not in initialization. > /* > * Sets up the vmcs for emulated real mode. > */ > @@ -4476,6 +4501,8 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx) > > vmcs_write64(POSTED_INTR_NV, POSTED_INTR_VECTOR); > vmcs_write64(POSTED_INTR_DESC_ADDR, __pa((&vmx->pi_desc))); > + > + pi_desc_init(vmx); > } > > if (ple_gap) { Best regards, Yang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/