Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751438AbaLRSC2 (ORCPT ); Thu, 18 Dec 2014 13:02:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbaLRSC1 (ORCPT ); Thu, 18 Dec 2014 13:02:27 -0500 Message-ID: <549316B1.8010307@redhat.com> Date: Thu, 18 Dec 2014 10:02:25 -0800 From: Andy Grover Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Kyle McMartin , linux-kernel@vger.kernel.org CC: nab@linux-iscsi.org, jbastian@redhat.com Subject: Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness References: <20141218175714.GF5157@redacted.bos.redhat.com> In-Reply-To: <20141218175714.GF5157@redacted.bos.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/2014 09:57 AM, Kyle McMartin wrote: > scripts/headers_install.sh will transform __packed to > __attribute__((packed)), so the #ifndef is not necessary. > (and, in fact, it's problematic, because we'll end up with the header > containing: > #ifndef __attribute__((packed)) > #define __attribu... > and so forth.) > > Cc: stable@vger.kernel.org # 3.18 > Signed-off-by: Kyle McMartin > > --- > cc-ing stable@ so this headers fix gets picked up by distros. Acked-by: Andy Grover -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/