Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbaLRWKm (ORCPT ); Thu, 18 Dec 2014 17:10:42 -0500 Received: from mail.kernel.org ([198.145.19.201]:51599 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbaLRWKk convert rfc822-to-8bit (ORCPT ); Thu, 18 Dec 2014 17:10:40 -0500 MIME-Version: 1.0 In-Reply-To: <20141218065848.29014.24886@quantum> References: <1417788934-23447-1-git-send-email-k.kozlowski@samsung.com> <1418129982.19339.6.camel@AMDC1943> <5486F69B.6020005@samsung.com> <7hlhmfo1b0.fsf@deeprootsystems.com> <7h8ui8h7n9.fsf@deeprootsystems.com> <1418718015.28527.4.camel@AMDC1943> <20141217152322.29014.7739@quantum> <20141218065848.29014.24886@quantum> Date: Thu, 18 Dec 2014 14:10:34 -0800 Message-ID: Subject: Re: [PATCH] clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable failure due to domain being gated From: Kevin Hilman To: Mike Turquette Cc: Krzysztof Kozlowski , Kevin Hilman , Sylwester Nawrocki , Tomasz Figa , Stephen Boyd , Kukjin Kim , "linux-samsung-soc@vger.kernel.org" , lkml , "linux-arm-kernel@lists.infradead.org" , Javier Martinez Canillas , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 17, 2014 at 10:58 PM, Mike Turquette wrote: > Quoting Mike Turquette (2014-12-17 07:23:22) >> Quoting Krzysztof Kozlowski (2014-12-16 00:20:15) >> > On pon, 2014-12-15 at 14:26 -0800, Kevin Hilman wrote: >> > > Kevin Hilman writes: >> > > >> > > > Sylwester Nawrocki writes: >> > > > >> > > >> On 09/12/14 13:59, Krzysztof Kozlowski wrote: >> > > >>> On pią, 2014-12-05 at 15:15 +0100, Krzysztof Kozlowski wrote: >> > > >>>> > Audio subsystem clocks are located in separate block. On Exynos 5420 if >> > > >>>> > clock for this block (from main clock domain) 'mau_epll' is gated then >> > > >>>> > any read or write to audss registers will block. >> > > >>>> > >> > > >>>> > This kind of boot hang was observed on Arndale Octa and Peach Pi/Pit >> > > >>>> > after introducing runtime PM to pl330 DMA driver. After that commit the >> > > >>>> > 'mau_epll' was gated, because the "amba" clock was disabled and there >> > > >>>> > were no more users of mau_epll. >> > > >>>> > >> > > >>>> > The system hang on one of steps: >> > > >>>> > 1. Disabling unused clocks from audss block. >> > > >>>> > 2. During audss GPIO setup (just before probing i2s0 because >> > > >>>> > samsung_pinmux_setup() tried to access memory from audss block which was >> > > >>>> > gated. >> > > >>>> > >> > > >>>> > Add a workaround for this by enabling the 'mau_epll' clock in probe. >> > > >>>> > >> > > >>>> > Signed-off-by: Krzysztof Kozlowski >> > > >>>> > --- >> > > >>>> > drivers/clk/samsung/clk-exynos-audss.c | 29 ++++++++++++++++++++++++++++- >> > > >>>> > 1 file changed, 28 insertions(+), 1 deletion(-) >> > > >>> >> > > >>> Sorry for pinging so quick but merge window is open and it looks like >> > > >>> booting Exynos542x boards will be broken (because pl330 will no longer >> > > >>> hold adma clock enabled so whole audss domain will be gated). >> > > >>> >> > > >>> This is a non-intrusive workaround for that issue, as wanted by >> > > >>> Sylwester: >> > > >>> https://lkml.org/lkml/2014/12/5/223 >> > > >>> >> > > >>> Any comments on this? >> > > >> >> > > >> The patch looks OK to me, it would be good though if someone else >> > > >> has confirmed it fixes the bug. I don't have any clock patches queued >> > > >> at the moment. Perhaps you could apply it directly, Mike ? >> > > > >> > > > I confirm it fixes the boot hang in linux-next (next-20141210) on my >> > > > exynos5800-peach-pi and exynos5420-arndale-octa. Tested both >> > > > exynos_defconfig and multi_v7_defconfig. >> > > > >> > > > Tested-by: Kevin Hilman >> > > >> > > What's the status of this patch? linux-next is still broken for several >> > > Exynos5 platforms without this fix. >> > >> > I believe not only next is broken but also current mainline because >> > runtime PM for pl330 was merged yesterday... >> > >> > The patch received two tested-bys (Kevin's and Javier's) and Sylwester's >> > ack. >> > >> > Mike, could you pick the patch and send it to Linus after rc1? >> >> Will do. > > To be clear, I pulled this into clk-next towards -rc1, so it won't need > to go through as an -rc fix. This hit today's linux-next, and exynos5 platforms are happily booting again. Thanks! Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/