Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbaLSApt (ORCPT ); Thu, 18 Dec 2014 19:45:49 -0500 Received: from casper.infradead.org ([85.118.1.10]:39298 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbaLSAps (ORCPT ); Thu, 18 Dec 2014 19:45:48 -0500 Date: Fri, 19 Dec 2014 00:45:45 +0000 From: Thomas Graf To: "Varlese, Marco" Cc: Roopa Prabhu , "netdev@vger.kernel.org" , "Fastabend, John R" , Jiri Pirko , "sfeldma@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration Message-ID: <20141219004545.GD16239@casper.infradead.org> References: <5492E85C.6010802@cumulusnetworks.com> <5492EFC3.8030102@cumulusnetworks.com> <549313B8.6050102@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/14 at 06:02pm, Varlese, Marco wrote: > Roopa, one of the comments I got from Thomas Graf on my v1 patch was that your patch and mine were supplementary ("I think Roopa's patches are supplementary. Not all switchdev users will be backed with a Linux Bridge. I therefore welcome your patches very much")... I also understood by others that the patch made sense for the same reason. I simply do not understand why these attributes (and maybe others in the future) could not be configured directly on a standard port but have to go through a bridge. Apologies for this confusion. I take that back. I was under the impression netdev_switch_port_bridge_setlink(), based on the "bridge" in the function name, would derive the attributes based on capabilities and assumption of the bridge module. This is not the case in the latest patchset proposed so it could indeed serve as the Netlink API for both the bridge and non bridge case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/