Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbaLSBlW (ORCPT ); Thu, 18 Dec 2014 20:41:22 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:33665 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbaLSBlU (ORCPT ); Thu, 18 Dec 2014 20:41:20 -0500 MIME-Version: 1.0 In-Reply-To: <20141218144915.GA29004@kahuna> References: <1418831495-26958-1-git-send-email-nm@ti.com> <20141218144915.GA29004@kahuna> Date: Fri, 19 Dec 2014 07:11:19 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: Stop BUGing the system From: Viresh Kumar To: Nishanth Menon Cc: Kevin Hilman , "Rafael J. Wysocki" , Linux Kernel Mailing List , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 December 2014 at 20:19, Nishanth Menon wrote: > I can add "could be unstable" -> the point being there can be psuedo > errors reported in the system - example - clock framework bugs. Dont > just stop the boot. example: what if cpufreq was a driver module - it > would not have rescued the system because cpufreq had'nt detected the > logic - if we are going to force this on the system, we should probably > not do this in cpufreq code, instead should be somewhere generic. > > While I do empathise (and had infact advocated in the past) of not > favouring system attempting to continue at an invalid configuration and > our attempt to rescue has failed - given that we cannot provide a > consistent behavior (it is not a core system behavior) and potential of > a false-postive (example clk framework or underlying bug), it should be > good enough to "enhance" WARN to be "severe sounding enough" to > flag it for developer and continue while keeping the system alive as > much as possible. There is no way out for the kernel to know if its a false positive or a real bug. And in the worst case, it can screw up a platform completely. I am still not sure if changing it to a WARN would be good idea. @Rafael: Thoughts ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/