Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751736AbaLSDtW (ORCPT ); Thu, 18 Dec 2014 22:49:22 -0500 Received: from mail.csclub.uwaterloo.ca ([129.97.134.52]:48338 "EHLO mail.csclub.uwaterloo.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbaLSDtV (ORCPT ); Thu, 18 Dec 2014 22:49:21 -0500 From: "Lennart Sorensen" Date: Thu, 18 Dec 2014 22:49:18 -0500 To: Len Sorensen Cc: Sebastian Hesselbarth , linux-kernel@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, Florian Fainelli , linuxppc-dev@lists.ozlabs.org, Li Yang Subject: net: ucc: tbi phy detection broken by 058112c7efc9ef43bb511c137293dddbe6e42908 Message-ID: <20141219034918.GX24110@csclub.uwaterloo.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I have been trying to move an 8360 based system from a 3.0 kernel to a 3.12 (on the way to 3.14 with ipipe/xenomai) kernel and encountered an oops in the ucc_geth driver when using RTBI mode on one of the ucc ports. I haven't managed to find any commits to of_mdio or ucc_geth or fsl_pq_mdio that would appear to address this problem, so I believe it is still present in the latest kernel, but have not confirmed that with testing yet. Commit 058112c7efc9ef43bb511c137293dddbe6e42908 appears to have broken ucc support for tbi phy detection. With the patch in place, I am unable to get the mdio bus to create phy devices for the tbi phy in the ucc on an 8360e, and the ucc_geth driver causes a kernel oops, while with the patch reverted, it does create them and the driver comes up and works. The tbi phy is needed when using a ucc in RTBI, TBI or SGMII mode. I am not convinced that the tbi phy really behaves quite like a real phy, which may be why get_phy_device does not work with it. Perhaps there is a better way to deal with the tbi phy on the ucc for this purpose. Certainly as it is, this patch has caused a regression though, although probably not very many systems with ucc ports actually use one of the affected modes so the damage isn't that great. -- Len Sorensen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/