Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbaLSG2f (ORCPT ); Fri, 19 Dec 2014 01:28:35 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:58033 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbaLSG2e (ORCPT ); Fri, 19 Dec 2014 01:28:34 -0500 Date: Fri, 19 Dec 2014 06:28:27 +0000 From: Al Viro To: Omar Sandoval Cc: Christoph Hellwig , Jan Kara , Andrew Morton , Trond Myklebust , David Sterba , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] swap: lock i_mutex for swap_writepage direct_IO Message-ID: <20141219062827.GV22149@ZenIV.linux.org.uk> References: <20141215221100.GA4637@mew> <20141216083543.GA32425@infradead.org> <20141216085624.GA25256@mew> <20141217080610.GA20335@infradead.org> <20141217082020.GH22149@ZenIV.linux.org.uk> <20141217082437.GA9301@infradead.org> <20141217145832.GA3497@mew> <20141217185256.GA5657@infradead.org> <20141217220313.GK22149@ZenIV.linux.org.uk> <20141219062405.GA11486@mew> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141219062405.GA11486@mew> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 18, 2014 at 10:24:05PM -0800, Omar Sandoval wrote: > + swap_file = file_open_name(name, O_RDWR | O_LARGEFILE | O_DIRECT, 0); > + if (IS_ERR(swap_file) && PTR_ERR(swap_file) == -EINVAL) ITYM if (swap_file == ERR_PTR(-EINVAL)) here... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/