Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbaLSKdy (ORCPT ); Fri, 19 Dec 2014 05:33:54 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:60769 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbaLSKdv convert rfc822-to-8bit (ORCPT ); Fri, 19 Dec 2014 05:33:51 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Joe Perches Cc: Thomas Gleixner , linux-arch , LKML , Geert Uytterhoeven , linux-m68k , Steven Miao , Ralf Baechle , linux-mips Subject: Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips) References: <1418849927.28384.1.camel@perches.com> <1418951658.28384.20.camel@perches.com> <1418954914.25129.1.camel@perches.com> Date: Fri, 19 Dec 2014 10:33:42 +0000 In-Reply-To: <1418954914.25129.1.camel@perches.com> (Joe Perches's message of "Thu, 18 Dec 2014 18:08:34 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: > On Fri, 2014-12-19 at 01:43 +0000, M?ns Rullg?rd wrote: >> What exactly are you proposing to remove? > > Optionally compile out > kernel/printk/printk.c:early_printk() > even if CONFIG_EARLY_PRINTK is enabled. > >> I see no unused code related >> to early printk (in any variant) under arch/mips. > > I think there could be yet another CONFIG option > to specifically enable the early_printk function > for the arches that use it. Why bother? On MIPS it would save 132 bytes of compiled code. > The kernel/printk/early_printk() function seems > used only by arm/microblaze/tile/x86. Rather than introduce more config complexity, you could try to remove the 7 remaining uses of early_printk(). - arch/arm/mach-socfpga Single early_printk("Early printk initialized\n") call serving no apparent purpose can probably be safely deleted. Since there are no other early_printk() calls, this information seems rather useless. - arch/microblaze, arch/tile, arch/x86 These all do a register_console() for the early console, so regular printk() should work. Moreover, x86 allows multiple early consoles, but calling early_printk() will only output to the last one specified. -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/