MIME-Version: 1.0
In-Reply-To: <1418412516-10682-1-git-send-email-bjorn.andersson@sonymobile.com>
References: <1418412516-10682-1-git-send-email-bjorn.andersson@sonymobile.com>
Date: Fri, 19 Dec 2014 12:38:07 +0100
Message-ID: <CAPDyKFrPC_MphsLHHZ=uFjcF8SsdkVmzez9R=gas7_ihn63Q5A@mail.gmail.com>
Subject: Re: [PATCH] mmc: dt: Add property for broken hs200 quirk
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Anton Vorontsov <anton@enomsg.org>, Chris Ball <chris@printf.net>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Grant Likely <grant.likely@linaro.org>,
        "open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:SECURE DIGITAL HO..." <linux-mmc@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

On 12 December 2014 at 20:28, Bjorn Andersson
<bjorn.andersson@sonymobile.com> wrote:

Some more explanation to why this needed would be good.

> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
>  Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++

This file lists the generic mmc DT bindings, but you want to add a
specific binding for sdhci?

>  drivers/mmc/host/sdhci-pltfm.c                | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
> index b52628b..04f80ef 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -22,6 +22,8 @@ Optional properties:
>  - wp-inverted: when present, polarity on the WP line is inverted. See the note
>    below for the case, when a GPIO is used for the WP line
>  - max-frequency: maximum operating clock frequency
> +- broken-hs200: when present, denotes that eMMC HS200 modes are not supported on
> +  this system, even if the controller claims it is.
>  - no-1-8-v: when present, denotes that 1.8v card voltage is not supported on
>    this system, even if the controller claims it is.
>  - cap-sd-highspeed: SD high-speed timing is supported
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index c5b01d6..570837f 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -90,6 +90,9 @@ void sdhci_get_of_property(struct platform_device *pdev)
>                 if (of_get_property(np, "broken-cd", NULL))
>                         host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> +               if (of_get_property(np, "broken-hs200", NULL))
> +                       host->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200;
> +
>                 if (of_get_property(np, "no-1-8-v", NULL))
>                         host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
>
> --
> 1.8.2.2
>

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/