Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbaLSOxs (ORCPT ); Fri, 19 Dec 2014 09:53:48 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:39959 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbaLSOxr (ORCPT ); Fri, 19 Dec 2014 09:53:47 -0500 Message-ID: <54943BF8.4050008@cogentembedded.com> Date: Fri, 19 Dec 2014 17:53:44 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Alexandre Belloni , Takashi Iwai CC: alsa-devel@alsa-project.org, Arnd Bergmann , Nicolas Ferre , linux-kernel@vger.kernel.org, Jaroslav Kysela , Alexander Stein , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform References: <1418944390-27719-1-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1418944390-27719-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/19/2014 2:13 AM, Alexandre Belloni wrote: > From: Arnd Bergmann > at91 will no longer export the mach/cpu.h and mach/hardware.h header files > in the future, which would break building the atmel ac97c driver. > Since the cpu_is_* check is only used to find out whether we are running > on avr32 or arm/at91, we can hardcode that check in the ARM case. > Unfortunately the driver is missing other work to be useful again on ARM, > if anyone wants to actually use it, they need to add a DT binding, and > the driver should really be converted to use the ASoC framework. > Signed-off-by: Arnd Bergmann > Link: http://www.spinics.net/lists/arm-kernel/msg382068.html > --- > sound/atmel/ac97c.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c > index b59427d5a697..83975f8d5947 100644 > --- a/sound/atmel/ac97c.c > +++ b/sound/atmel/ac97c.c > @@ -34,10 +34,10 @@ > #include > #include > > +#ifdef CONFIG_AVR32 > #include > - > -#ifdef CONFIG_ARCH_AT91 > -#include > +#else > +#define cpu_is_at32ap7000() (0) () around 0 not needed at all. [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/