Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbaLSR1q (ORCPT ); Fri, 19 Dec 2014 12:27:46 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:40749 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbaLSR1p (ORCPT ); Fri, 19 Dec 2014 12:27:45 -0500 Date: Fri, 19 Dec 2014 18:27:28 +0100 From: Peter Zijlstra To: Andy Lutomirski Cc: Shaohua Li , "linux-kernel@vger.kernel.org" , X86 ML , Kernel-team@fb.com, "H. Peter Anvin" , Ingo Molnar , John Stultz Subject: Re: [PATCH v2 3/3] X86: Add a thread cpu time implementation to vDSO Message-ID: <20141219172728.GN30905@twins.programming.kicks-ass.net> References: <8559794d3a1924408a811a2881ab916fffb6015b.1418857018.git.shli@fb.com> <95a7ba1a95a6251439d5ca2d3d56fe7f0778cb95.1418857018.git.shli@fb.com> <20141219112350.GJ30905@twins.programming.kicks-ass.net> <20141219170334.GM30905@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 19, 2014 at 09:07:49AM -0800, Andy Lutomirski wrote: > Re-asking my old question: would it make sense to add a vdso helper > for the magic self-monitoring interface? Or, at the very least, we > could try to tidy up the docs a bit. I find it really helps (performance wise) to strip down that magic to the bare minimum required. A VDSO helper would always have to do everything. I suppose we could provide a generic helper, one can always hand code the stuff anyhow. Then again, what is the benefit of having it in the VDSO as opposed to a regular DSO? Updating the docs is always good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/