Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752143AbaLTAxL (ORCPT ); Fri, 19 Dec 2014 19:53:11 -0500 Received: from omr2.cc.vt.edu ([198.82.141.100]:59876 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbaLTAxK (ORCPT ); Fri, 19 Dec 2014 19:53:10 -0500 X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6+dev To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, sgrubb@redhat.com, eparis@parisplace.org, pmoore@redhat.com Subject: Re: [PATCH] audit: use supplied gfp_mask from audit_buffer in kauditd_send_multicast_skb In-Reply-To: Your message of "Thu, 18 Dec 2014 23:09:27 -0500." From: Valdis.Kletnieks@vt.edu References: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1419036779_71557P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Fri, 19 Dec 2014 19:52:59 -0500 Message-ID: <74385.1419036779@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1419036779_71557P Content-Type: text/plain; charset=us-ascii On Thu, 18 Dec 2014 23:09:27 -0500, Richard Guy Briggs said: > Eric Paris explains: Since kauditd_send_multicast_skb() gets called in > audit_log_end(), which can come from any context (aka even a sleeping context) > GFP_KERNEL can't be used. Since the audit_buffer knows what context it should > use, pass that down and use that. > > See: https://lkml.org/lkml/2014/12/16/542 > Reported-by: Valdis Kletnieks > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 7b83c55..ce484fb 100644 I was reliably triggering 3-4 BUGs an hour, and with this patch applied I've gone 9 hours without seeing one. So feel free to add a Tested-By: when it goes out. --==_Exmh_1419036779_71557P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Exmh version 2.5 07/13/2001 iQIVAwUBVJTIawdmEQWDXROgAQIDJA/+Pv0vIe0ZSKyOPJQunXcryqefTBW5K/HB nS21Vo73VxO2h5Kg7JI9JUQJz0FvFDvKX9sgAlpTnjTSciiUQ9U2aqI/mCGDXHuO 6+CVRf+cvqPkU68caW8h8pq230R/z0rm+oaozvh8RWQpX/+p2IhVHAXVW1grNB4O Uv5JvOmj2fY03o0Z3k3NV+5FMuTXjDJiZE3n6ZF3NboZaeTZ20F+jfcma6+wzTaL KSNTOa7BfcCUb/PgtXuYYDrTru1uFSfBffKfHthxSOP7/nYwxZcicSCyxY22Z7h0 gZoWUX8WTwE/SF+IEbjGMjzXCV1eJYFIP2qreSdeiCLv2nmsgNzuGlaLo96TtuO1 SkXTWU7DGf2/u87eQqi/xq9YasEudwkzhOOHfEjBH41lbBqv/w7DvDnG98hJVdEg HcuewU+dfhyG81lRTR5ojClxlg8PbudtbzvEx24emdtPeu/qTdXf9BGncJ9A3CBt UINxjLLH70qrqUHW6ZMS8uOvtci9ahKh/C2PK3ph1jPbO010pwdvfm1Y+KPx/k/z JA5nunkwjTWxolUU17GKG5qN/FhM/NM9SSoI3WRvMTBhD+755F8YckvrL4NvwI6v q7Q2kh1wDqZ5JGAY87w/1up0ObLMOkc3UeVTgppRcuWYUSnNSUBUEYKeHZx9FCMX Of6pTdG9h6M= =CK1Y -----END PGP SIGNATURE----- --==_Exmh_1419036779_71557P-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/