Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753420AbaLTQux (ORCPT ); Sat, 20 Dec 2014 11:50:53 -0500 Received: from mail-pd0-f178.google.com ([209.85.192.178]:50236 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402AbaLTQut (ORCPT ); Sat, 20 Dec 2014 11:50:49 -0500 Date: Sat, 20 Dec 2014 08:50:45 -0800 From: Jeremiah Mahler To: Rickard Strandqvist Cc: Finn Thain , Michael Schmitz , Russell King , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: arm: cumana_1.c: Remove unused function Message-ID: <20141220165045.GA5013@hudson.localdomain> Mail-Followup-To: Jeremiah Mahler , Rickard Strandqvist , Finn Thain , Michael Schmitz , Russell King , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1419093375-8016-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1419093375-8016-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote: > Remove the function cumanascsi_setup() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/scsi/arm/cumana_1.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c > index 8ef810a..7c90d9c 100644 > --- a/drivers/scsi/arm/cumana_1.c > +++ b/drivers/scsi/arm/cumana_1.c > @@ -38,10 +38,6 @@ > > #include "../NCR5380.h" > > -void cumanascsi_setup(char *str, int *ints) > -{ > -} > - > const char *cumanascsi_info(struct Scsi_Host *spnt) > { > return ""; [...] You can blame Linus for this one :-) ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void cumanascsi_setup(char *str, int *ints) ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) { ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) } ~/linux-next$ -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/