Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbaLTWad (ORCPT ); Sat, 20 Dec 2014 17:30:33 -0500 Received: from mail-qg0-f51.google.com ([209.85.192.51]:33368 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbaLTWac (ORCPT ); Sat, 20 Dec 2014 17:30:32 -0500 From: Paul Moore To: Valdis.Kletnieks@vt.edu Cc: Richard Guy Briggs , linux-audit@redhat.com, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, sgrubb@redhat.com, eparis@parisplace.org Subject: Re: [PATCH] audit: use supplied gfp_mask from audit_buffer in kauditd_send_multicast_skb Date: Sat, 20 Dec 2014 17:30:29 -0500 Message-ID: <1707208.eM92rXqJdO@sifl> User-Agent: KMail/4.14.3 (Linux/3.16.7-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <74385.1419036779@turing-police.cc.vt.edu> References: <74385.1419036779@turing-police.cc.vt.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, December 19, 2014 07:52:59 PM Valdis.Kletnieks@vt.edu wrote: > On Thu, 18 Dec 2014 23:09:27 -0500, Richard Guy Briggs said: > > Eric Paris explains: Since kauditd_send_multicast_skb() gets called in > > audit_log_end(), which can come from any context (aka even a sleeping > > context) GFP_KERNEL can't be used. Since the audit_buffer knows what > > context it should use, pass that down and use that. > > > > See: https://lkml.org/lkml/2014/12/16/542 > > > > Reported-by: Valdis Kletnieks > > Signed-off-by: Richard Guy Briggs > > --- > > > > kernel/audit.c | 8 ++++---- > > 1 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/kernel/audit.c b/kernel/audit.c > > index 7b83c55..ce484fb 100644 > > I was reliably triggering 3-4 BUGs an hour, and with this patch applied I've > gone 9 hours without seeing one. > > So feel free to add a Tested-By: when it goes out. Added, thanks for your help. -- paul moore security @ redhat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/