Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbaLUN5m (ORCPT ); Sun, 21 Dec 2014 08:57:42 -0500 Received: from mail-vc0-f170.google.com ([209.85.220.170]:34310 "EHLO mail-vc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753057AbaLUN5l (ORCPT ); Sun, 21 Dec 2014 08:57:41 -0500 MIME-Version: 1.0 In-Reply-To: <20141221205604.5a280c9d@canb.auug.org.au> References: <1419094041-14536-1-git-send-email-bobby.prani@gmail.com> <20141221205604.5a280c9d@canb.auug.org.au> From: Pranith Kumar Date: Sun, 21 Dec 2014 08:57:10 -0500 Message-ID: Subject: Re: [PATCH] powerpc: Wire up sys_execveat() syscall To: Stephen Rothwell Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Anton Blanchard , David Herrmann , Andrew Morton , Fabian Frederick , "open list:LINUX FOR POWERPC..." , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 21, 2014 at 4:56 AM, Stephen Rothwell wrote: > Hi Pranith, > > On Sat, 20 Dec 2014 11:47:18 -0500 Pranith Kumar wrote: >> >> Wire up sys_execveat(). This passes the selftests for the system call. > > Thanks for this, but ... > >> diff --git a/arch/powerpc/include/asm/systbl.h b/arch/powerpc/include/asm/systbl.h >> index ce9577d..778844a 100644 >> --- a/arch/powerpc/include/asm/systbl.h >> +++ b/arch/powerpc/include/asm/systbl.h >> @@ -366,3 +366,4 @@ SYSCALL_SPU(seccomp) >> SYSCALL_SPU(getrandom) >> SYSCALL_SPU(memfd_create) >> SYSCALL_SPU(bpf) >> +SYSCALL_SPU(execveat) > > Given that it passes pointers into the kernel and looking at the execve > system call, I assume that it should be COMPAT_SYS(). > Yes, you are right. I will send in an updated patch. Thanks! -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/