Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbaLUXWZ (ORCPT ); Sun, 21 Dec 2014 18:22:25 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:46670 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbaLUXWY (ORCPT ); Sun, 21 Dec 2014 18:22:24 -0500 MIME-Version: 1.0 In-Reply-To: <1419183632-10349-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1419183632-10349-1-git-send-email-rickard_strandqvist@spectrumdigital.se> From: Rob Herring Date: Sun, 21 Dec 2014 17:22:02 -0600 Message-ID: Subject: Re: [PATCH] scripts: dtc: libfdt: fdt_rw.c: Remove some unused functions To: Rickard Strandqvist Cc: Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 21, 2014 at 11:40 AM, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > fdt_delprop() fdt_add_mem_rsv() > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > scripts/dtc/libfdt/fdt_rw.c | 32 ----------------------------- > scripts/dtc/libfdt/libfdt.h | 48 ------------------------------------------- > 2 files changed, 80 deletions(-) These sources are just imported unmodified from libfdt, so we don't want to be changing them in the kernel. Also, I think these functions could be needed at some point. Getting -ffunction-sections to work with the kernel would be the right way to solve this IMHO. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/