MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8BIT
Message-id: <54977D7C.9040307@samsung.com>
Date: Mon, 22 Dec 2014 11:10:04 +0900
From: jonghwa3.lee@samsung.com
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411
 Thunderbird/11.0.1
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, sre@kernel.org,
        dbaryshkov@gmail.com, dwmw2@infradead.org, anton@enomsg.org,
        myungjoo.ham@samsung.com, cw00.choi@samsung.com
Subject: Re: [PATCH V3 08/11] power: charger-manager: Make chraging decision
 focusing on battery status.
References: <1418979323-7188-1-git-send-email-jonghwa3.lee@samsung.com>
 <1418979323-7188-9-git-send-email-jonghwa3.lee@samsung.com>
 <20141220002440.GC1694@amd>
In-reply-to: <20141220002440.GC1694@amd>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org

On 2014년 12월 20일 09:24, Pavel Machek wrote:

> Subject: charging.
> 


(snip..)


>> --- a/include/linux/power/charger-manager.h
>> +++ b/include/linux/power/charger-manager.h
>> @@ -220,6 +220,7 @@ struct charger_desc {
>>   *	saved status of battery before entering suspend-to-RAM
>>   * @charging_start_time: saved start time of enabling charging
>>   * @charging_end_time: saved end time of disabling charging
>> + * @battery_status: Current battery status
> 
> "current" for consistency.
> 
>>   */
>>  struct charger_manager {
>>  	struct list_head entry;
>> @@ -237,6 +238,8 @@ struct charger_manager {
>>  
>>  	u64 charging_start_time;
>>  	u64 charging_end_time;
>> +
>> +	int battery_status;
>>  };
> 
> Should battery_status be some kind of enum?


Currently, it stores only enum of power_supply class's and it doesn't have
specified type. And also, I didn't want to make additional private enums.
I'd let it to be as it was.

Thanks,
Jonghwa

> 									Pavel
> --						
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/