Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753903AbaLVCih (ORCPT ); Sun, 21 Dec 2014 21:38:37 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:42486 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753794AbaLVCif (ORCPT ); Sun, 21 Dec 2014 21:38:35 -0500 MIME-Version: 1.0 In-Reply-To: <1419007551-10040-2-git-send-email-atull@opensource.altera.com> References: <1419007551-10040-1-git-send-email-atull@opensource.altera.com> <1419007551-10040-2-git-send-email-atull@opensource.altera.com> From: Rob Herring Date: Sun, 21 Dec 2014 20:38:13 -0600 Message-ID: Subject: Re: [PATCH v7 1/4] doc: add bindings document for altera fpga manager To: Alan Tull Cc: Greg Kroah-Hartman , Jason Gunthorpe , "H. Peter Anvin" , Michal Simek , Michal Simek , Randy Dunlap , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Pantelis Antoniou , Rob Herring , Grant Likely , iws@ovro.caltech.edu, "linux-doc@vger.kernel.org" , Pavel Machek , Mark Brown , Philip Balister , Alessandro Rubini , Steffen Trumtrar , Jason Cooper , Kyle Teske , Nicolas Pitre , Felipe Balbi , Mauro Carvalho Chehab , David Brown , Rob Landley , David Miller , Cesar Eduardo Barros , Samuel Ortiz , Andrew Morton , Linus Walleij , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devel@driverdev.osuosl.org, Alan Tull , Dinh Nguyen , "yvanderv@opensource.altera.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 19, 2014 at 10:45 AM, wrote: > From: Alan Tull > > New bindings document for Altera fpga manager. > > Signed-off-by: Alan Tull > --- > v5 : Move bindings to drivers/staging/fpga/Documentation/bindings > > v6 : No change in this patch for v6 of the patch set > > v7 : No change in this patch for v7 of the patch set > --- > .../Documentation/bindings/altera-fpga-mgr.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt > > diff --git a/drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt b/drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt > new file mode 100644 > index 0000000..373af7b > --- /dev/null > +++ b/drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt > @@ -0,0 +1,17 @@ > +Altera FPGA Manager > + > +Required properties: > +- compatible : should contain "altr,fpga-mgr" > +- reg : base address and size for memory mapped io. > + - The first index is for FPGA manager register access. > + - The second index is for writing FPGA configuration data. > +- interrupts : interrupt for the FPGA Manager device. > + > +Example: > + > + hps_0_fpgamgr: fpgamgr@0xff706000 { > + compatible = "altr,fpga-mgr"; Is "FPGA Manager" what the block is called or the name for the Linux subsystem?" The name should reflect the h/w block name. Also, is the block the same in every chip? This binding doesn't look complex or likely to change, so it can be out of staging unless you expect it to change. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/