Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbaLVDau (ORCPT ); Sun, 21 Dec 2014 22:30:50 -0500 Received: from mail-wg0-f54.google.com ([74.125.82.54]:42276 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692AbaLVDas (ORCPT ); Sun, 21 Dec 2014 22:30:48 -0500 MIME-Version: 1.0 In-Reply-To: References: <1418408748-9797-1-git-send-email-vishnupatekar0510@gmail.com> <548C1E7D.1000005@redhat.com> <548D5207.8030004@redhat.com> <548EFA9F.4080208@redhat.com> Date: Mon, 22 Dec 2014 09:00:45 +0530 Message-ID: Subject: Re: [PATCHv3 0/5] ARM:sunxi:ps2 Added support for A10/A20 ps2 controller. From: Vishnu Patekar To: Chen-Yu Tsai Cc: Hans de Goede , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "jdelvare@suse.de" , "linux@arm.linux.org.uk" , "pawel.moll@arm.com" , "ijc+devicetree@hellion.org.uk" , "benh@kernel.crashing.org" , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , "ralf@linux-mips.org" , "robh+dt@kernel.org" , "msalter@redhat.com" , "linux-input@vger.kernel.org" , Grant Likely , Kumar Gala , "maxime.ripard@free-electrons.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for delayed response. Thanks, Chen-Yu. So, I'll keep ps2 enabled for Lime2 board without any comment. On Mon, Dec 15, 2014 at 9:11 PM, Chen-Yu Tsai wrote: > Hi, > > On Mon, Dec 15, 2014 at 11:13 PM, Hans de Goede wrote: >> Hi, >> >> >> On 15-12-14 15:13, Vishnu Patekar wrote: >>> >>> Hi, >>> >>> On Sun, Dec 14, 2014 at 2:31 PM, Hans de Goede >>> wrote: >>>> >>>> Hi, >>>> >>>> On 13-12-14 21:01, Vishnu Patekar wrote: >>>>> >>>>> >>>>> Hello Hans, >>>>> Please find my comments inlined. >>>>> >>>>> On 12/13/14, Hans de Goede wrote: >>>>>> >>>>>> >>>>>> Hi VishnuPatekar, >>>>>> >>>>>> The patch mangling for this set seems to have gone a bit wrong I'm >>>>>> afraid >>>>> >>>>> >>>>> >>>>> No, this time I've corrected it. Infact, last version of patch did not >>>>> used the status bit error macros. >>>>> >>>>>> a lot of the patches have my fixup commit messages (which should have >>>>>> disappeared when squashing in the patches), please replace those by >>>>>> proper >>>>>> commit messages describing what the patch actually does. >>>>> >>>>> >>>>> Yes, [PATCHv3 3/5] uses fixup. I'll correct it. >>>>>> >>>>>> >>>>>> >>>>>> Also the adding of the commented nodes for the lime2 seems to be gone >>>>>> entirely >>>>>> from the set, instead now only a comment about the conflict with the >>>>>> hdmi >>>>>> pins is added, but it is above the i2c node instead of above a ps2 >>>>>> node. >>>>>> >>>>> Maxime's suggested that we should not add commented nodes specially >>>>> when its trivial to apply. And just note saying ps20 pins conflict >>>>> with HDMI. >>>> >>>> >>>> >>>> Ah, I see. >>>> >>>>> Should I remove the this comment as well? >>>>> Or >>>>> Put this note in start of DTS file? >>>> >>>> >>>> >>>> The comment should be added to where the pinctrl bits are, not to the >>>> lime2 >>>> file, ps0 will conflict with hdmi on all boards. >>> >>> >>> Well, In that case,PS2_0 pins conflicts with HDMI, PS2_1 pins >>> conflicts with LCD. Every pin has multiplexing. >> >> >> Almost every A10 board has a hdmi connector, and only the hdmi ddc pins >> are multiplexed, so this is sort of special, but yes if we do not have >> the commented nodes in the dts file, then this comment can be dropped too >> I guess. > > All the HDMI pins have dedicated pins. In addition, the DDC pins are > multiplexed. On the Lime, the dedicated pins (ball # R23, R22) are > used. I just checked the schematics. There should be no conflict. > > ChenYu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/